2016-11-08 13:03:34 +00:00
|
|
|
import pytest
|
|
|
|
import sys
|
|
|
|
|
|
|
|
with pytest.suppress(ImportError):
|
|
|
|
import numpy as np
|
|
|
|
|
|
|
|
|
2016-08-12 11:50:00 +00:00
|
|
|
def test_vector_int():
|
|
|
|
from pybind11_tests import VectorInt
|
|
|
|
|
|
|
|
v_int = VectorInt([0, 0])
|
|
|
|
assert len(v_int) == 2
|
|
|
|
assert bool(v_int) is True
|
|
|
|
|
|
|
|
v_int2 = VectorInt([0, 0])
|
|
|
|
assert v_int == v_int2
|
|
|
|
v_int2[1] = 1
|
|
|
|
assert v_int != v_int2
|
|
|
|
|
|
|
|
v_int2.append(2)
|
|
|
|
v_int2.append(3)
|
|
|
|
v_int2.insert(0, 1)
|
|
|
|
v_int2.insert(0, 2)
|
|
|
|
v_int2.insert(0, 3)
|
|
|
|
assert str(v_int2) == "VectorInt[3, 2, 1, 0, 1, 2, 3]"
|
|
|
|
|
|
|
|
v_int.append(99)
|
|
|
|
v_int2[2:-2] = v_int
|
|
|
|
assert v_int2 == VectorInt([3, 2, 0, 0, 99, 2, 3])
|
|
|
|
del v_int2[1:3]
|
|
|
|
assert v_int2 == VectorInt([3, 0, 99, 2, 3])
|
|
|
|
del v_int2[0]
|
|
|
|
assert v_int2 == VectorInt([0, 99, 2, 3])
|
|
|
|
|
|
|
|
|
2017-04-14 21:50:44 +00:00
|
|
|
# As of pypy 5.7.1, running this and the next test seems to trigger a segfault
|
|
|
|
# related to the PyPy's buffer protocol.
|
2016-11-08 13:03:34 +00:00
|
|
|
@pytest.unsupported_on_pypy
|
|
|
|
def test_vector_buffer():
|
|
|
|
from pybind11_tests import VectorUChar, create_undeclstruct
|
|
|
|
b = bytearray([1, 2, 3, 4])
|
|
|
|
v = VectorUChar(b)
|
|
|
|
assert v[1] == 2
|
|
|
|
v[2] = 5
|
|
|
|
m = memoryview(v) # We expose the buffer interface
|
|
|
|
if sys.version_info.major > 2:
|
|
|
|
assert m[2] == 5
|
|
|
|
m[2] = 6
|
|
|
|
else:
|
|
|
|
assert m[2] == '\x05'
|
|
|
|
m[2] = '\x06'
|
|
|
|
assert v[2] == 6
|
|
|
|
|
|
|
|
with pytest.raises(RuntimeError):
|
|
|
|
create_undeclstruct() # Undeclared struct contents, no buffer interface
|
|
|
|
|
|
|
|
|
2017-04-14 21:50:44 +00:00
|
|
|
@pytest.unsupported_on_pypy
|
2016-11-08 13:03:34 +00:00
|
|
|
@pytest.requires_numpy
|
|
|
|
def test_vector_buffer_numpy():
|
2016-11-21 17:40:43 +00:00
|
|
|
from pybind11_tests import VectorInt, VectorStruct, get_vectorstruct
|
2016-11-08 13:03:34 +00:00
|
|
|
|
|
|
|
a = np.array([1, 2, 3, 4], dtype=np.int32)
|
|
|
|
with pytest.raises(TypeError):
|
|
|
|
VectorInt(a)
|
|
|
|
|
|
|
|
a = np.array([[1, 2, 3, 4], [5, 6, 7, 8], [9, 10, 11, 12]], dtype=np.uintc)
|
|
|
|
v = VectorInt(a[0, :])
|
|
|
|
assert len(v) == 4
|
|
|
|
assert v[2] == 3
|
|
|
|
m = np.asarray(v)
|
|
|
|
m[2] = 5
|
|
|
|
assert v[2] == 5
|
|
|
|
|
|
|
|
v = VectorInt(a[:, 1])
|
|
|
|
assert len(v) == 3
|
|
|
|
assert v[2] == 10
|
|
|
|
|
|
|
|
v = get_vectorstruct()
|
|
|
|
assert v[0].x == 5
|
|
|
|
m = np.asarray(v)
|
|
|
|
m[1]['x'] = 99
|
|
|
|
assert v[1].x == 99
|
|
|
|
|
2016-11-21 17:40:43 +00:00
|
|
|
v = VectorStruct(np.zeros(3, dtype=np.dtype([('w', 'bool'), ('x', 'I'),
|
|
|
|
('y', 'float64'), ('z', 'bool')], align=True)))
|
|
|
|
assert len(v) == 3
|
|
|
|
|
2016-11-08 13:03:34 +00:00
|
|
|
|
2016-08-12 11:50:00 +00:00
|
|
|
def test_vector_custom():
|
|
|
|
from pybind11_tests import El, VectorEl, VectorVectorEl
|
|
|
|
|
|
|
|
v_a = VectorEl()
|
|
|
|
v_a.append(El(1))
|
|
|
|
v_a.append(El(2))
|
|
|
|
assert str(v_a) == "VectorEl[El{1}, El{2}]"
|
|
|
|
|
|
|
|
vv_a = VectorVectorEl()
|
|
|
|
vv_a.append(v_a)
|
|
|
|
vv_b = vv_a[0]
|
|
|
|
assert str(vv_b) == "VectorEl[El{1}, El{2}]"
|
|
|
|
|
|
|
|
|
|
|
|
def test_vector_bool():
|
|
|
|
from pybind11_tests import VectorBool
|
|
|
|
|
|
|
|
vv_c = VectorBool()
|
|
|
|
for i in range(10):
|
|
|
|
vv_c.append(i % 2 == 0)
|
|
|
|
for i in range(10):
|
|
|
|
assert vv_c[i] == (i % 2 == 0)
|
|
|
|
assert str(vv_c) == "VectorBool[1, 0, 1, 0, 1, 0, 1, 0, 1, 0]"
|
2016-08-30 02:50:38 +00:00
|
|
|
|
2016-11-20 20:21:54 +00:00
|
|
|
|
2016-08-30 02:50:38 +00:00
|
|
|
def test_map_string_double():
|
|
|
|
from pybind11_tests import MapStringDouble, UnorderedMapStringDouble
|
|
|
|
|
|
|
|
m = MapStringDouble()
|
|
|
|
m['a'] = 1
|
|
|
|
m['b'] = 2.5
|
|
|
|
|
2016-11-20 20:21:54 +00:00
|
|
|
assert list(m) == ['a', 'b']
|
|
|
|
assert list(m.items()) == [('a', 1), ('b', 2.5)]
|
2016-08-30 02:50:38 +00:00
|
|
|
assert str(m) == "MapStringDouble{a: 1, b: 2.5}"
|
|
|
|
|
|
|
|
um = UnorderedMapStringDouble()
|
|
|
|
um['ua'] = 1.1
|
|
|
|
um['ub'] = 2.6
|
|
|
|
|
2016-11-20 20:21:54 +00:00
|
|
|
assert sorted(list(um)) == ['ua', 'ub']
|
|
|
|
assert sorted(list(um.items())) == [('ua', 1.1), ('ub', 2.6)]
|
|
|
|
assert "UnorderedMapStringDouble" in str(um)
|
2016-08-30 02:50:38 +00:00
|
|
|
|
|
|
|
|
|
|
|
def test_map_string_double_const():
|
|
|
|
from pybind11_tests import MapStringDoubleConst, UnorderedMapStringDoubleConst
|
|
|
|
|
|
|
|
mc = MapStringDoubleConst()
|
|
|
|
mc['a'] = 10
|
|
|
|
mc['b'] = 20.5
|
|
|
|
assert str(mc) == "MapStringDoubleConst{a: 10, b: 20.5}"
|
|
|
|
|
|
|
|
umc = UnorderedMapStringDoubleConst()
|
|
|
|
umc['a'] = 11
|
|
|
|
umc['b'] = 21.5
|
|
|
|
|
|
|
|
str(umc)
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
2016-11-20 20:21:54 +00:00
|
|
|
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
def test_noncopyable_vector():
|
2016-11-20 20:21:54 +00:00
|
|
|
from pybind11_tests import get_vnc
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
vnc = get_vnc(5)
|
|
|
|
for i in range(0, 5):
|
2016-11-20 20:21:54 +00:00
|
|
|
assert vnc[i].value == i + 1
|
|
|
|
|
|
|
|
for i, j in enumerate(vnc, start=1):
|
|
|
|
assert j.value == i
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
|
|
|
|
def test_noncopyable_deque():
|
2016-11-20 20:21:54 +00:00
|
|
|
from pybind11_tests import get_dnc
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
dnc = get_dnc(5)
|
|
|
|
for i in range(0, 5):
|
2016-11-20 20:21:54 +00:00
|
|
|
assert dnc[i].value == i + 1
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
i = 1
|
|
|
|
for j in dnc:
|
|
|
|
assert(j.value == i)
|
|
|
|
i += 1
|
|
|
|
|
2016-11-20 20:21:54 +00:00
|
|
|
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
def test_noncopyable_map():
|
2016-11-20 20:21:54 +00:00
|
|
|
from pybind11_tests import get_mnc
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
mnc = get_mnc(5)
|
|
|
|
for i in range(1, 6):
|
2016-11-20 20:21:54 +00:00
|
|
|
assert mnc[i].value == 10 * i
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
vsum = 0
|
|
|
|
for k, v in mnc.items():
|
2016-11-20 20:21:54 +00:00
|
|
|
assert v.value == 10 * k
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
vsum += v.value
|
|
|
|
|
2016-11-20 20:21:54 +00:00
|
|
|
assert vsum == 150
|
|
|
|
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
def test_noncopyable_unordered_map():
|
2016-11-20 20:21:54 +00:00
|
|
|
from pybind11_tests import get_umnc
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
mnc = get_umnc(5)
|
|
|
|
for i in range(1, 6):
|
2016-11-20 20:21:54 +00:00
|
|
|
assert mnc[i].value == 10 * i
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
|
|
|
|
vsum = 0
|
|
|
|
for k, v in mnc.items():
|
2016-11-20 20:21:54 +00:00
|
|
|
assert v.value == 10 * k
|
Fix stl_bind to support movable, non-copyable value types (#490)
This commit includes the following changes:
* Don't provide make_copy_constructor for non-copyable container
make_copy_constructor currently fails for various stl containers (e.g.
std::vector, std::unordered_map, std::deque, etc.) when the container's
value type (e.g. the "T" or the std::pair<K,T> for a map) is
non-copyable. This adds an override that, for types that look like
containers, also requires that the value_type be copyable.
* stl_bind.h: make bind_{vector,map} work for non-copy-constructible types
Most stl_bind modifiers require copying, so if the type isn't copy
constructible, we provide a read-only interface instead.
In practice, this means that if the type is non-copyable, it will be,
for all intents and purposes, read-only from the Python side (but
currently it simply fails to compile with such a container).
It is still possible for the caller to provide an interface manually
(by defining methods on the returned class_ object), but this isn't
something stl_bind can handle because the C++ code to construct values
is going to be highly dependent on the container value_type.
* stl_bind: copy only for arithmetic value types
For non-primitive types, we may well be copying some complex type, when
returning by reference is more appropriate. This commit returns by
internal reference for all but basic arithmetic types.
* Return by reference whenever possible
Only if we definitely can't--i.e. std::vector<bool>--because v[i]
returns something that isn't a T& do we copy; for everything else, we
return by reference.
For the map case, we can always return by reference (at least for the
default stl map/unordered_map).
2016-11-15 11:30:38 +00:00
|
|
|
vsum += v.value
|
|
|
|
|
2016-11-20 20:21:54 +00:00
|
|
|
assert vsum == 150
|